Wireshark · Ethereal-dev: Re: [Ethereal-dev] eaptls defragmentation support

[Guy Harris <gharris@xxxxxxxxx>]

On Tue, Mar 26, 2002 at 07:07:21PM -0800, Guy Harris wrote:
> Well, it has more global variables than I'd like; I'd prefer to have the
> state information be attached to the conversation (for example, adding
> an "eap_state_t" structure, which contains the conversation state, which
> would include both the EAP-TLS defragmentation state and the LEAP state,
> and keeping "leap_state_t" around for per-frame state, with two separate
> memory chunks for them).

I've checked in your change, modified to do something along those
lines...

> In addition, you might want to use the EAP ID variable to detect
> duplicate fragments and the like.  This means that the "reassemble.h"
> code might not be what you'd use - but that was designed for IP-style
> reassembly, where you have a fragment ID field that's common to all
> fragments, and a byte offset, rather than an ID field that serves, in
> effect, as a fragmentation offset.

...and to use the EAP ID of the first fragment as the key, and to use
the ordinal number of the fragment as the "offset", using
"fragment_add_seq()" rather than "fragment_add()".)