Ethereal-dev: [Ethereal-dev] Two patches, packet-q931 and packet-tpkt

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: andreas.sikkema@xxxxxxxxxxx
Date: Mon, 25 Mar 2002 09:50:11 +0100
Hi,

Here are two patches which I hope can be included in 0.9.3, both
are useability related.:

1. packet-q931.c Moves the H.225 contents of the UU-IE from
   the IE-tree to the same level of the protocol tree as the other
   protocols. Normally the interesting bits of H.225 are two
   branches or more deep in the protocol, you don't want to travel
   4 or 5 levels deep into a protocol to find useful info, so this patch
   removes at least two.
2. packet-tpkt.c If packet-tpkt is used to dissect fragmented tcp packets,
   and is allowed to really dissect the frame, this patch will clear the
   summary info, so dissectors called by dissect_tpkt can append
   info to the column. without the column being polluted by "unnecessary"
   information

Example of the tpkt patch:
  Without this patch some frames might look like this:
    TPKT length=12 MasterSlaveDetermination TPKT length=2 MasterslaveDeterminationAck TPKT length=4 TerminalCapabilitySetAck
  With the patch:
    MasterSlaveDetermination MasterslaveDeterminationAck TerminalCapabilitySetAck

Which is much more useable IMHO.

The patch for packet-tpkt might need a little more work but I don't have
any other captures including TPKT use to verify this feeling.

(See attached file: packet-tpkt.c.diff)(See attached file: packet-q931.c.diff)

--
Andreas Sikkema
andreas.sikkema@xxxxxxxxxxx
"While you're waiting, read the free novel we sent you.
 It's a Spanish story about a guy named `Manual'" - Dilbert

Attachment: packet-tpkt.c.diff
Description: Binary data

Attachment: packet-q931.c.diff
Description: Binary data