Ethereal-dev: Re: [Ethereal-dev] packet-skinny.c modifications

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 18 Mar 2002 22:38:50 -0800
On Thu, Mar 14, 2002 at 12:15:53AM -0500, Paul E. Erkkila wrote:
> Attached is a work in progress modification of the packet-skinny.c
> done by Joerg Mayer (ethereal 0.9.1). I did not provide a diff as
> it was almost the same size as the file ;p. I'm new to ethereal
> dev work but would like to know how to get this and further
> changes into the working version.

I've checked in changes to do desegmentation of SCCP messages; if TCP
desegmentation and SCCP desegmentation are both enabled (TCP
desegmentation is off by default; SCCP desegmentation is on by default),
SCCP packets split across TCP segment boundaries will be reassembled.

I also made it put items into the protocol tree as soon as they are
fetched, so that if some of those items are past the end of the tvbuff,
earlier items still get put into the protocol tree.

It appears that, in at least one capture I have, a RegisterMessage has
only 40 bytes of data, so the last two fields in the message don't exist
(the desegmentation code constructs a tvbuff for each PDU, so if the
dissector runs past the end of the length in the header, an exception is
thrown and a "Malformed Packet" item is put in the tree).