Ethereal-dev: [Ethereal-dev] [patch] "crash" in eapol

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Adam <adam@xxxxxxxxxxxx>
Date: Mon, 11 Mar 2002 03:22:31 -0500 (EST)
this fixes annying abort in packet-eapol.

by the way, is there any way that ethereal handled aborts/crashes more
gracefully. currently if I try run it under gdb, at some instances when it
crashes it will take control of WM with it. as result I have to switch to
some VC kill ethereal and switch back before I can do anything in X.

Is ethereal usinsg 'Override-Redirect' (as defined in XConfigureWindow
or XCreateWindow) or something?


-- 
Adam
http://www.eax.com	The Supreme Headquarters of the 32 bit registers
fixes annoying abort on ASSERT() in ethereal.

[root@localhost ethereal]# ./ethereal -r eapol-key.dump
** ERROR **: file proto.c: line 1264 (proto_tree_add_boolean): assertion 
failed: (hfinfo->type == FT_BOOLEAN)
aborting...
Aborted
[root@localhost ethereal]#

        Adam Sulmicki <adam@xxxxxxxxxxxx>
	Mon Mar 11 03:05:36 EST 2002
        http://www.eax.com/patches/

-------------------------------------------------------------------------------

Index: packet-eapol.c
===================================================================
RCS file: /cvsroot/ethereal/packet-eapol.c,v
retrieving revision 1.8
diff -u -r1.8 packet-eapol.c
--- packet-eapol.c	2002/02/22 23:05:16	1.8
+++ packet-eapol.c	2002/03/11 08:05:31
@@ -160,7 +160,7 @@
       key_index_tree = proto_item_add_subtree(ti, ett_eapol_key_index);
       proto_tree_add_boolean(eapol_tree, hf_eapol_keydes_key_index_keytype,
 			     tvb, offset, 1, key_index);
-      proto_tree_add_boolean(eapol_tree, hf_eapol_keydes_key_index_indexnum,
+      proto_tree_add_uint(eapol_tree, hf_eapol_keydes_key_index_indexnum,
 			     tvb, offset, 1, key_index);
       offset += 1;
       proto_tree_add_item(eapol_tree, hf_eapol_keydes_key_signature, tvb,