Ethereal-dev: [Ethereal-dev] Small bug in Ethereal IEEE 802.11 dissection

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jouni Malinen <jkmaline@xxxxxxxxx>
Date: Sat, 9 Mar 2002 09:26:45 +0200
There is a small bug in adding IEEE 802.11 authentication frame data
to proto tree. Authentication seq# and alg are always added as
1 (=TRUE) due to wrong function being called. Patch included below.


Index: packet-ieee80211.c
===================================================================
RCS file: /cvsroot/ethereal/packet-ieee80211.c,v
retrieving revision 1.51
diff -u -u -r1.51 packet-ieee80211.c
--- packet-ieee80211.c  2002/02/22 07:16:35     1.51
+++ packet-ieee80211.c  2002/03/09 07:08:11
@@ -586,11 +586,11 @@
       break;
 
     case FIELD_AUTH_ALG:
-      proto_tree_add_uint (tree, ff_auth_alg, tvb, offset, 2, TRUE);
+      proto_tree_add_item (tree, ff_auth_alg, tvb, offset, 2, TRUE);
       break;
 
     case FIELD_AUTH_TRANS_SEQ:
-      proto_tree_add_uint (tree, ff_auth_seq, tvb, offset, 2, TRUE);
+      proto_tree_add_item (tree, ff_auth_seq, tvb, offset, 2, TRUE);
       break;
 
     case FIELD_CURRENT_AP_ADDR:


-- 
Jouni Malinen                                            PGP id EFC895FA