Ethereal-dev: Re: [Ethereal-dev] packet-sccp.c patch for compilation under Win32

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jeff Morriss <jeff.morriss@xxxxxxxxxxx>
Date: Wed, 06 Mar 2002 14:54:53 -0500
David Frascone wrote:
> 
> On Wednesday, 06 Mar 2002, Jeff Morriss wrote:
> >
> > Actually, that patch will break the intended functionality :(.
> >
> > Does the attached patch fix VC++'s complaint?
> >
> > If not, the offending statement should be broken into:
> >
> > if (called)
> >       called_ssn = ssn;
> > else
> >       calling_ssn = ssn;
> 
> That might have been the intended functionality, but it is definately
> *not* what the code was doing, before *or* after the patch.

Oops.  I guess I was lulled into a false sense of security (or
something) by gcc (2.96) which understood what I meant (and generated
code to that affect, too).  <sigh>
begin:vcard 
n:Morriss;Jeff
tel;fax:+1-856-222-9947
tel;work:+1-856-787-2824
x-mozilla-html:FALSE
url:http://www.ulticom.com
org:Ulticom, Inc.;Customer Support
version:2.1
email;internet:jeff.morriss[AT]ulticom.com
title:Senior Support Engineer
adr;quoted-printable:;;Ulticom, Inc.=0D=0A1020 Briggs Rd.=0D=0A;Mount Laurel;NJ;08054;USA
fn:Jeff Morriss
end:vcard