Ethereal-dev: Re: [Ethereal-dev] patch for Openwave WSP decoding

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 21 Feb 2002 23:26:03 -0800
On Thu, Feb 21, 2002 at 04:12:51PM -0000, Dermot Bradley wrote:
> Attached is a patch to packet-wsp.c which adds decoding of Openwave headers.

Checked in (with routines added for the common code between the standard
and Openwave headers).

The patch was done as a regular diff rather than a context diff or a
unified diff; regular diffs work as patches only if the version being
patched is the same as the version used to do the diff - if the patch is
applied to a different version, and the line numbers have changed, the
patch doesn't apply correctly.  Context diffs and unified diffs don't
have that problem, so we (and most other recipients of patches) prefer
patches to be supplied as context or unified diffs.

In addition, it was a reverse diff, with the "before" file being the
modified file and the "after" file being the original file; this also
makes it a bit more of a pain to apply the patch.