Ethereal-dev: [Ethereal-dev] SAMR dissector patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Ronnie Sahlberg" <sahlberg@xxxxxxxxxxxxxxxx>
Date: Thu, 7 Feb 2002 03:14:54 +1100
Hi list,
updates to SAMR dissector.

first the good news,
the dissector now dissects all of SAMR, i.e. every structure and every call,
including the
calls where the names of the function is unknown.

now the bad news,
there are bound to be quite a few bugs still in the dissector due to lack of
testing.
one area where I am unsure of how the NDR representation is encoded are
toplevel
parameters such as : [out, ref] SID **sid
which I currently dissect as if it would be just a top level reference
pointer, thus the encoding
would be just the representation of the SID structure/array.
I dont know if this is correct or not, one alternative way to dissect
something like this is
[0 bytes, top level reference pointer, i.e. not encoded in NDR][4 bytes,
embedded reference pointer] [SID representation]

I have no way of knowing which way is correct, but will fix any bugs that
are reported.
Feedback appreciated.


Attachment: dcerpc.diff
Description: Binary data