Hi,
Ok good reason.
However myself I try to make all fields filterable. It is a lot of extra
work, especially for fields
that none is not ever likely to use, but you never know:-)
I also think there were a few value_string arrays that did not have a proper
{0, NULL}
terminator in them.
I think you might want to check this in the dissector. I would assume
val_to_str() would dump core
if the terminator is missing and someone tries to look up something not in
the table.
thank you for contributing to ethereal,
ronnie sahlberg
----- Original Message -----
From: "Paul Ionescu" <paul@xxxxxxxx>
To: "Ronnie Sahlberg" <sahlberg@xxxxxxxxxxxxxxxx>
Cc: <ethereal-dev@xxxxxxxxxxxx>
Sent: Wednesday, December 26, 2001 10:10 PM
Subject: Re: [Ethereal-dev] Initial DLSw dissector
> Hi Ronnie,
>
> I put proto_tree_add_text() in all the dissected values because this is
> an initial dissector for DLSW and right now I am interested in how
> accurate is the dissection of the protocol.
> Later on, in a second version, I will convert some of them to
> proto_tree_add_item(), to be able to use them in display filters.
> However, I don't think that we need proto_tree_add_item() for every
> item, but just for some important ones that worth filtering on.
> And this is what I expect to find meanwhile, the important fields to
> filter on.
> Otherwise, we will end up with a BIG bunch of unuseful filtering fields,
> or at least this is my impression.
> So, in the end, we will have some fields to filter on, but only the
> important ones.
> Now, give it a try and send me your impressions about it.
>
> Best regards and Merry Xmass.
> Paul
>
> Ronnie Sahlberg wrote:
> >
> > Hi Paul, list
> >
> > Great work.
> >
> > Just a small comment,
> > All dissected values are displayed with proto_tree_add_text() which
means
> > that there are
> > no hf_* fields for display filter handling.
> > Is it possible in a later version that the proto_tree_add_text() get
changed
> > to
> > proto_tree_add_item() instead and that the appropriate hf_* fields are
> > defined?
> >
> > best regards
> > ronnie sahlberg
> >
> > ----- Original Message -----
> > From: "Paul Ionescu"
> > Sent: Wednesday, December 26, 2001 4:46 AM
> > Subject: [Ethereal-dev] Initial DLSw dissector
> >
> > > Hello and Merry Xmass to everybody,
> > >
> > > I just made a initial dissector of DLSw (RFC 1434, RFC 1795, RFC 2166)
> > > and I attached it to this e-mail with some demo capture of dlsw
packets.
> > > If it is ok, please comit it to the ethereal.
> > >
> > > Thank you.
