Ethereal-dev: Re: [Ethereal-dev] Van Jacobson dissector.

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxxxxxxx>
Date: Wed, 19 Dec 2001 16:39:07 -0600
On Wed, 19 Dec 2001 16:28:46 Irfan Khan wrote:
> 
> >We just had an issue with this type of struct-casting
> >in tcp_graph.c. We stay away from this. Because hdr_buf is
> >being allocated from a GMemChunk, it might be aligned
> >properly for what you're doing. Any opinions on this?
> 
> 
> I couldn't find tcp_graph.c ??

It's gtk/tcp_graph.c in the CVS repository; it will be in the
next release. If you don't use our anonymous CVS access, you
can download nightly source-code snapshosts at:

http://www.ethereal.com/distribution/nightly-builds/
 
> > >
> > >   /* Store the reconstructed header in frame data area */
> > >   buf_hdr = g_mem_chunk_alloc(vj_header_memchunk);
> >
> >I don't see a g_mem_chunk_free() call for the buf_hdr's that
> >are allocated.
> 
> 
> I use g_mem_chunk_destroy in the initialization function for vj for that.
> 

Okay. Thanks,

--gilbert