Ethereal-dev: Re: [Ethereal-dev] First version of LSA pipe dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 17 Dec 2001 00:33:32 -0800
On Mon, Dec 17, 2001 at 09:05:29AM +0900, Motonori Shindo wrote:
> MSVC++ doesn't like the goto statement in this code for some
> reason.

Actually, the problem isn't with the goto, it's with the statement after
the label to which the goto is going...

...or, rather, with the *lack* of a statement after the goto.

GCC may not mind

	if (...) {

	done:
	}

but other compilers would require


	if (...) {

	done:
		;
	}

I'll add another item to the "how to write more portable code" bit in
"README.developer" about this.

However, I think it's a bit cleaner if we just get rid of the gotos
entirely, so that's what I checked in.