Ethereal-dev: [Ethereal-dev] WTP reassembly patch; alternatives please

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Tom Uijldert <Tom.Uijldert@xxxxxx>
Date: Wed, 12 Dec 2001 13:38:09 +0100
Hi all,

Attached a patch on packet-wtp.c to handle reasssembly.

It's a bit dodgy because "fragment_add()" works with offsets in the packet
and WTP works with packet sequence numbers. I'm therefore not happy with the
solution (which won't work in certain situations).

Would it be a good idea to have a 'fragment_add_seq()" function that does
the same but with sequence numbers instead of offsets (lot of
code-duplication though) or change the current "fragment_add()" to accept
sequence-numbers as well?

Furthermore, I think that "fragment_add()" does not allow for insertion of
re-transmitted packets (or did I miss something)?

Regards,
Tom Uijldert          Email: Tom.Uijldert@xxxxxx

Attachment: packet-wtp.c.diff
Description: Binary data