Ethereal-dev: [Ethereal-dev] Re: SMB transaction reassembly patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Pia Sahlberg" <piabar@xxxxxxxxxxx>
Date: Tue, 27 Nov 2001 23:33:57 +0000
Hi list,

Re my earlier patch,
I just thought,
maybe the checks before calling the subdissectors from dissect_transaction_response() is a bit too restrictive. 

I think of the one of the form  if( r_tvb && p_tvb && d_tvb)
since it just struck me that there might be cases where
p_tvb is NULL (i.e. no parameters, only data)

Perhaps it should be changed to be just if (r_tvb)
(or if(r_tvb && d_tvb)   but could tehre be cases where only parameters
are specified and no data in the Transaction call?)
If none else looks into it I will tonight.



_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp