Ethereal-dev: [Ethereal-dev] CHECK_DISPLAY_AS_DATA

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ed Warnicke <hagbard@xxxxxxxxxxxxxxxxxxx>
Date: 25 Nov 2001 01:04:21 -0500
Is the CHECK_DISPLAY_AS_DATA macro still necessary?  

It seems that any dissector that gets called should be called via a call
to 

call_dissector()
dissector_try_port()
or
dissector_try_heuristic()

all of which check for the protocol being enabled themselves.

The reason I ask is that I am in the process of moving 
dissect_data to 
a)	Being of type dissect_t ( it's current signature is off by the
	presence of the int offset parameter).
b)	Being called by call_dissector() whereever it is needed.

This removes dissect_data from the list of symbols in libethereal.a that
are not resolvable within itself ( or from libc, glib or libwiretap).

So is there a good reason for keeping CHECK_DISPLAY_AS_DATA around?

Ed

Attachment: pgpzxVGV7UyY2.pgp
Description: PGP signature