Ethereal-dev: Re: [Ethereal-dev] Memory leak and packet_info structure.

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Fri, 2 Nov 2001 17:22:55 -0800 (PST)
(Your message would have been easier to read had it been split into
paragraphs....)

> In proto.c there is also a minor memory leak in "void
> proto_cleanup(void)".  You should replace:"if(gpa_hfinfo)
> g_ptr_array_free(gpa_hfinfo, FALSE);"by"if(gpa_hfinfo)
> g_ptr_array_free(gpa_hfinfo, TRUE);"

Fixed, although "minor" really means "extremely minor", as
"proto_cleanup()" is only called just before exiting, at present.

> Finally, is it possible in
> ethereal-0.8.20 to rename the variable "private" in the structure
> packet_info, because when I link my project wrote in C++ with
> ethereal-0.8.20 I have an error (even if I use extern "C").
> you.

It certainly would be possible for you to apply to Ethereal 0.8.20 the
fix that I just checked into the Ethereal source tree to rename it to
"private_data", although Ethereal 0.8.20 will continue to have it called
"private" as it's already been released - the fix will show up in the
next release.