Ethereal-dev: Re: [Ethereal-dev] autoconf patches/questions for 0.8.19

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxxxxxxx>
Date: Mon, 20 Aug 2001 09:52:16 -0500
On Mon, 20 Aug 2001 06:02:46 ethereal-dev@xxxxxxxxxxxxxxxxxx wrote:
> 1. Why do you include AM_PATH_GLIB in wiretap/acinclude.m4? It's
>    customary for acinclude.m4 to contain local macros and for
>    aclocal.m4 to contain acinclude.m4 and 3rd-party macros. Is
>    the version of AM_PATH_GLIB in wiretap/acinclude.m4 different
>    from that distributed in the glib tarball?

This happened a long time ago, back when glib 1.1.x was under development,
back when glib was just being split from gtk+. At that time, if I
remember correctly, you *had* to use AM_PATH_GTK to test for the
existence of glib; that is, glib was already split from gtk in
the development branch, but separate automake macros for glib and gtk+
did not exist yet.  I grabbed a copy of AM_PATH_GLIB from
somewhere and stuck it in acinclude.m4.

Now that many suns have passed, yes, this could be removed
from acinclude.m4.

> 2. Any reason not to use the ACTION-IF-NOT-FOUND part of the
>    AC_CHECK_FUNC macro (patch below)?
> 3. "config.h" should be included before any other headers (patches
>    below to gtk/gtkclist.c, wiretap/ascend-grammar.y,
>    wiretap/ascend-scanner.l).

Thanks. I'll check the changes in.

--gilbert