Ethereal-dev: Re: [Ethereal-dev] SDP patch?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 18 Jun 2001 21:57:18 -0700
On Sat, Jun 09, 2001 at 08:30:50AM -0600, PC Drew wrote:
> Did anyone receive the SDP patch I sent?

Yes, we did.

"dissect_sdp()" allocates a bunch of stuff, not all of which appears to
be freed or to have pointers to it stored persistently, e.g. the
"conn_list" and "media_list" arrays.

Unless that data is referred to elsewhere, it needs to be freed when
"dissect_sdp()" returns; it *also* needs to be freed if any of the tvb_
routines throw an exception.

Note also that you can use "inet_aton()" to convert dotted-quad strings
into IP addresses - you don't have to use "atoi()" and "strtok()".