I'll check it in. BTW what are you using RSVP for, if I may ask?
-Ashok
On Thu, 14 Jun 2001 14:17:33 -0400, Craig Rodrigues <rodrigc@xxxxxxxxxxxx>
wrote:
> Hi,
>
> Thanks to the developer who wrote the original RSVP dissector.
> I am working a lot with RSVP these days, and Ethereal has
> been invaluable in helping me debug and diagnose RSVP problems.
> Using Ethereal, and by reading the RSVP RFC's, I was able
> to solve a few problems in my testbed.
>
> I have a patch to correct the text in some of the fields
> in the display.
>
> RFC 2210, Section 3.1 "RSVP SENDER_TSPEC Object" defines
> a quantity called "Maximum Packet Size [M]", not "Maximum Policed Unit".
>
> --
> Craig Rodrigues
> http://www.gis.net/~craigr
> rodrigc@xxxxxxxxxxxx
>
> --- packet-rsvp.c.orig Thu Jun 14 14:04:51 2001
> +++ packet-rsvp.c Thu Jun 14 14:05:47 2001
> @@ -1214,10 +1214,10 @@
> "Peak data rate: %ld",
> tvb_ieee_to_long(tvb, offset2+12));
> proto_tree_add_text(rsvp_object_tree, tvb, offset2+16, 4,
> - "Minimum policed unit: %u",
> + "Minimum policed unit [m]: %u",
> tvb_get_ntohl(tvb, offset2+16));
> proto_tree_add_text(rsvp_object_tree, tvb, offset2+20, 4,
> - "Maximum policed unit: %u",
> + "Maximum packet size [M]: %u",
> tvb_get_ntohl(tvb, offset2+20));
> proto_item_set_text(ti, "SENDER TSPEC: IntServ, %lu
bytes/sec",
> tvb_ieee_to_long(tvb,
offset2+4));
> @@ -1319,10 +1319,10 @@
> "Peak data rate: %ld",
> tvb_ieee_to_long(tvb, offset2+12));
> proto_tree_add_text(rsvp_object_tree, tvb, offset2+16, 4,
> - "Minimum policed unit: %u",
> + "Minimum policed unit [m]: %u",
> tvb_get_ntohl(tvb, offset2+16));
> proto_tree_add_text(rsvp_object_tree, tvb, offset2+20, 4,
> - "Maximum policed unit: %u",
> + "Maximum packet size [M]: %u",
> tvb_get_ntohl(tvb, offset2+20));
>
> if (service_num != QOS_GUARANTEED) {
> @@ -1373,7 +1373,7 @@
> param_id,
> tvb_get_ntohs(tvb, offset2+2));
> proto_tree_add_text(rsvp_object_tree, tvb, offset2+4, 4,
> - "Maximum policed unit: %u",
> + "Maximum packet size [M]: %u",
> tvb_get_ntohl(tvb, offset2+4));
>
> proto_item_set_text(ti, "FLOWSPEC: Qualitative");
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
--- Asok the Intern ----------------------------------------
Ashok Narayanan
IOS Network Protocols, Cisco Systems
250 Apollo Drive, Chelmsford, MA 01824
Ph: 978-244-8387. Fax: 978-244-8126 (Attn: Ashok Narayanan)
