Ethereal-dev: Re: [Ethereal-dev] incorrect L2TP tie breaker decode

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 9 Jun 2001 21:45:40 -0700
On Fri, Jun 08, 2001 at 07:18:22PM -0700, Guy Harris wrote:
> Declare a bunch of named fields for the various AVP values (rather than
> incorrectly using "hf_l2tp_code", as the dissector currently does), and
> make the 64-bit value an FT_BYTES field - it'll get displayed as raw hex
> digits.
> 
> In fact, by doing that, you can also get rid of a pile of
> "proto_tree_add_uint_format()" calls and replace them with
> "proto_tree_add_item()" calls, which do a lot of the work for you.

Or just do them all with "proto_tree_add_text()", which is what I did
for now; in the process, I cleaned up a bunch of problems with the AVP
dissection.