Ethereal-dev: Re: [Ethereal-dev] Signed/Unsigned warning fixes (gryphon,lemon)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 24 Apr 2001 02:18:44 +0200
On Mon, Apr 23, 2001 at 04:47:06PM -0700, Guy Harris wrote:
> With which compiler was this, and, if it was with GCC, with which
> version was this, and with which "-W" flag was this?  At least with
> "-Wall" with GCC 2.95.1 on SPARC/Solaris, I wasn't getting any warnings.

This is gcc 2.95.2. If you look into the man page you will find, that
-Wall is *not* producing all things gcc knows about. -W will turn on
some more warnings, some of them useful, some not. In case you want
to look at it yourself, I've attached the change in my configure.in.
If you really want to, you may check it in and ask everyone to go
and hunt for warnings. Btw. there's one warning about a comparison
always evaluating to true in packet-socks.c, but I'm not there yet :-)

 Ciao
    Jörg

-- 
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.

Index: ethereal/configure.in
===================================================================
RCS file: /cvsroot/ethereal/configure.in,v
retrieving revision 1.120
diff -u -u -r1.120 configure.in
--- configure.in	2001/04/19 01:08:16	1.120
+++ configure.in	2001/04/24 00:13:25
@@ -87,7 +87,7 @@
 # If we're running gcc, add '-Wall' to CFLAGS.
 AC_MSG_CHECKING(to see if we can add '-Wall' to CFLAGS)
 if test x$GCC != x ; then
-  CFLAGS="-Wall $CFLAGS"
+  CFLAGS="-Wall -W $CFLAGS"
   AC_MSG_RESULT(yes)
 else
   AC_MSG_RESULT(no)