Ethereal-dev: Re: [Ethereal-dev] Total indepedence of epan/ethereal.lib

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ed Warnicke <hagbard@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 13 Apr 2001 15:30:52 -0400 (EDT)
As I said before... I hadn't had time to look at the issue closely.
It seems likely that etype_vals is declared extern through 
packet.h for dissectors that use it.  In general I'd rather 
see the dependencies more explicitely expressed. 

Ed

On Fri, 13 Apr 2001, Guy Harris wrote:

> > There is also an extern dependency on etype_vals[], which is 
> > defined in packet-ethertype.c ( and also appears to depend on etypes.h).
> 
> "etype_vals[]" doesn't appear to be used anywhere in libethereal; it
> just happens to be declared in "etypes.h" - which doesn't appear to be
> included by anything in the "epan" directory.
> 
> Perhaps "etypes.h" should be moved back into the top-level directory?
>