Ethereal-dev: Re: [Ethereal-dev] Crash in packet-icmpv6.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 28 Mar 2001 13:29:22 -0800 (PST)
> On Wed, Mar 28, 2001 at 11:39:12PM +0300, Heikki Vatiainen wrote:
> > #7  0x809d57c in dissect_icmpv6 (pd=0x821fc60 "", offset=58,
> >     fd=0x82cac80, tree=0x82ddb80) at packet-icmpv6.c:991
> 
> Replace proto_tree_add_item_hidden with proto_tree_add_boolean_hidden at
> this line.

(Which you've just done in the CVS tree.)

Yes, and the same should be done with all the other calls to add a "bad
checksum" flag - the dissectors in question are tvbuffified, so they
won't crash, but they'll add the checksum field as the Boolean's value,
which may be equivalent to "true", but is still wrong; I'll check those
in.