Ethereal-dev: Re: [Ethereal-dev] packet-stat.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Thu, 15 Mar 2001 14:10:23 -0800 (PST)
> packet-stat.c was an empty skeleton file.
> 
> I have implemented all dissectors for version 1 of the protocol.

Checked in.

> attached is also a capture file for all procedures defined for stat v1.

That revealed a problem - "proto_tree_add_item()" was being called
regardless of whether the "tree" argument was null, but, unlike the
other "proto_tree_add" routines, it didn't check for a null "tree"
argument and just return NULL if the "tree" argument is null.

I've checked in a fix to make "proto_tree_add_item()" check for a null
"tree" argument, following the Principle Of Least Astonishment.