Wireshark · Ethereal-dev: Re: [Ethereal-dev] VJ compressed PPP packets ??

[Guy Harris <gharris@xxxxxxxxxxxx>]

On Mon, Mar 05, 2001 at 10:47:02AM -0600, Jeff Foster wrote:
> Attempt #2:
> 
> I have changed the basic concept from byte view to data source. I
> think this is a better indication of the concept that there are
> multiple data items. The current changes that I plan -
> 
> 1) Modified the tvbuff struct to add the ds_name -
> 
> #define DS_NAME_LEN 64
> 
> 	gchar ds_name[ DS_NAME_LEN];

Why an array rather than a pointer to an arbitrary-length string, so
that:

> 2) The tvb_new_real_data function is changed to add a ds_name field
> 
> tvbuff_t*
> tvb_new_real_data( const guint8* data, guint length,
> 	gint reported_length, const gchar* ds_name);

it'd do

	tvb->ds_name = g_strdup(ds_name);

> 5) Add a ds_name field to the field_info struct
> 
> 	gchar ds_name[ DS_NAME_LEN];

Ditto.

> 7) Change dissect_packet to create the tvbuff with the name "raw".

I'm assuming the name would be what shows up on the tab; would "Frame"
be a better name, to indicate that the initial data source is the data
in the current frame?