Ethereal-dev: Re: [Ethereal-dev] Re: TCP graphs for ethereal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Sat, 24 Feb 2001 16:09:58 -0800
Some problems with the current version of the code:

	1) It uses C++-style comments to comment code out - not all C
	   compilers accept C++-style comments.

	2) It relies on the OS's headers to specify the layout of
	   link-layer, IP, and TCP headers - and does so in a fashion
	   that causes it not to compile on, for example, FreeBSD 3.4.

	   It should, instead, define those data structures itself; note
	   that Ethereal doesn't depend on the OS's headers to supply
	   packet layouts and, as of tcpdump 3.6.1 and libpcap 0.6.1,
	   tcpdump and libpcap don't depend on them, either - it's just
	   too much of a pain to do so, given that those headers may
	   differ significantly from platform to platform.

	3) It's Ethernet-specific and IPv4-specific.