Ethereal-dev: Re: [Ethereal-dev] New feature for ethereal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: David Hampton <dhampton@xxxxxxx>
Date: Sat, 20 Jan 2001 21:29:35 -0800
guy> On Thu, Jan 18, 2001 at 06:33:12PM -0800, David Hampton wrote:
guy> > +#ifdef DEBUG
guy> > +#define dprintf(...) printf(...)
guy> > +#else
guy> > +#define dprintf(...)
guy> > +#endif
guy> 
guy> That's not legal C89; perhaps it's legal in the new ANSI C
guy> standard, but using it would mean that a large number of C
guy> compilers out there couldn't compile it.

You can pull all the debugging lines if you want.  I just left them
for convenience if I or anyone else had to work on the iterators in
the future.

guy> > +    gchar *string, *text[E_CLIST_S_MAX];
guy> 
guy> That should be
guy> 
guy> 	     gchar *string, *text[E_CLIST_S_COLUMNS];
guy> 

You're absolutely correct.  Do you want me to correct it and resubmit
the diffs?

David