Ethereal-dev: Re: [Ethereal-dev] GPRS tunnelling protocol(GTP)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Sat, 16 Dec 2000 01:46:05 -0800
On Fri, Dec 15, 2000 at 10:26:53PM -0600, Shen Chun (EUS) wrote:
>            Preliminary release,  only compiled under VC++, against
> gcc later.

Some comments:

	1) "dissect_gtp()" should be made static - it's not called
	   directly from anywhere else.

	2) The "NEW_INTERFACE" stuff should be removed - the code should
	   always use tvbuffs.

	3) That means that "packet-gtp.h" is not necessary - there would
	   be no need to define (or undefine) NEW_INTERFACE, and there's
	   no need to declare "dissect_gtp()".

	4) As "dissect_gtp()" should use tvbuffs, it should be
	   registered with "dissector_add()", not "old_dissector_add()".

	5) The names for fields used in packet filters should probably
	   be all lower-case, for typing convenience - e.g.,
	   "gtp.qosprofile", not "gtp.QoSprofile".