Ethereal-dev: Re: [Ethereal-dev] packet-aim patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Mon, 27 Nov 2000 22:38:22 -0800
On Thu, Nov 23, 2000 at 04:10:55PM -0500, Ralf Holzer wrote:
> the attached patch fixes some minor bugs and adds simple
> support for signon/offs and chats rooms.

It also changes some "col_add_str()" calls to "col_add_fstr()" calls,
without changing the arguments; any call of the form

	col_add_fstr(fd, COL_xxx, "This is a string with no formatting items");

is equivalent to

	col_add_str(fd, COL_xxx, "This is a string with no formatting items");

"col_add_fstr()" is necessary only if you have a "printf"-style format.

(In fact, if the string is a constant, "col_add_str()" can be replaced
by "col_set_str()"; however, you may use "col_set_str()" only if the
string is a static string and won't change - it sets a pointer to point
to the string in question, and if that pointer isn't valid after the
dissector returns, Random Things Happen.)