Ethereal-dev: Re: [Ethereal-dev] Patch for packet-smb-logon.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <sharpe@xxxxxxxxxx>
Date: Tue, 21 Nov 2000 16:32:41 +1000
At 10:14 AM 11/21/00 +0100, andreas.sikkema@xxxxxxxxxxx wrote:
>Hi,
>
>A collegue of mine found a bug in packet-smb-logon.c while he was 
>looking for browsing problems on his network. Attached are a patch 
>to resolve this particular problem and a capture file which shows 
>this bug.

The bug comes about because the strings in this case are UNICODE, but the
SMB-Logon stuff does not check for UNICODE. 

I think that a UNICODE flag is passed to the parent of SMB-LOGON, so I will
look at that tomorrow. 

The patch as it stands will break the display of other LOGON requests (that
do not have UNICODE in them).


>There is also another bug I think, if you look at the dissected 
>(logon) message, you will see that the LM token is shown as being 
>0xffffffff, but it should be 0xffff
>
>
>
>-- 
>Andreas Sikkema
>andreas.sikkema@xxxxxxxxxxx
>
>Attachment Converted: "c:\eudora\attach\pdc.cap"
>
>Attachment Converted: "c:\eudora\attach\smb-logon.patch"
>

Regards
-------
Richard Sharpe, sharpe@xxxxxxxxxx
Samba (Team member, www.samba.org), Ethereal (Team member, www.zing.org)
Contributing author, SAMS Teach Yourself Samba in 24 Hours
Author, Special Edition, Using Samba