Ethereal-dev: Re: [Ethereal-dev] giop dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: itojun@xxxxxxxxxx
Date: Sun, 12 Nov 2000 11:48:45 +0900
>*However*, by "identified as GIOP", do you mean they're dissected as GIOP,
>or just that they have "GIOP" in the protocol column?  If the latter,
>that's another bug, which I just noticed when looking at the code - it
>sets the protocol column *before* doing all the heuristic checks.

	the protocol column says "GIOP", the TCP frame data is not decoded.
	so i believe the issue is exactly as you say (should update
	protocol column after heuristic check)

>I'll move that after the heuristic checks, so it sets the column to
>"GIOP" only if it actually accepts the packet as a GIOP packet.

itojun