Ethereal-dev: Re: [Ethereal-dev] MGCP plugin

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ed Warnicke <hagbard@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 8 Nov 2000 22:45:47 -0500 (EST)
OK.  Here is the correction to that problem as well as several others 
plus a bit of cleanup .  Please check this out and then check it in if it 
looks good to you.

Ed

On Wed, 8 Nov 2000 Gilbert_Ramirez@xxxxxxxxxx wrote:

> I assume that in this section of packet-mgcp.c:
> 
> static gint tvb_crlf_strip(tvbuff_t *tvb, gint offset, gint maxlength){
>   gint returnvalue;
>   guint8 tempchar;
> 
>   for(returnvalue = maxlength;
>       ( (returnvalue >= 0 ) && (
>         ((tempchar = tvb_get_guint8(tvb,offset + returnvalue) ) == 'r')  ||
>         (tempchar == '\n')));
>       returnvalue--);
>   return ( returnvalue );
> }
> 
> 
> you meant to compare the return value of tvb_get_guint() against '\r' instead of 'r'. ???
> 
> --gilbert
> 
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>

Attachment: ethereal_plugin_mgcp-0.1.tar.gz
Description: Revised version of the ethereal/plugin/mgcp directory