Ethereal-dev: RE: [Ethereal-dev] AIM / OSCAR dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Jeff Foster <jfoste@xxxxxxxxxxxx>
Date: Thu, 2 Nov 2000 09:08:09 -0600
per Ralf Holzer -

> I just wrote a dissector for the OSCAR protocol used by AOL Instant 
> Messenger. (OSCAR is the closed protocol used by the "official" clients).
> 
> The code is probably not quite ready for prime time, but it dissects the
most 
> important parts of OSCAR traffic. There are still some issues with the 
> correct offsets for the messages, because they vary from client to client.
> 
> I know there is lots of room for improvement, but I would appreciate it,
if I 
> could get some feedback on it.
> 

Welcome to ethereal development. 

One thing that I see is you are using the old style dissectors not the new
(and
improved) tvbuffer style dissectors. It looks like the code was cut and
paste
from the README.developer so it isn't really your fault. I posted a new
version
of README.developer to the mailing list last week. I thought it was going to
make
the 8.13 release, however it didn't and isn't in the CVS tree. Our mistake.
I can
send you a copy of it if you want. I know this will more changes then you
expect,
but we really need to write dissectors using tvbuffers.

Thanks for the code.

Jeff Foster
jfoste@xxxxxxxxxxxx