Ethereal-dev: Re: [Ethereal-dev] Patches for WAP Support

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Thu, 19 Oct 2000 00:27:03 -0700
On Mon, Oct 16, 2000 at 04:42:03PM +0100, Neil Hunter wrote:
> Finally! At last I've managed to grab the latest CVS code and rework my WAP
> code into it. As a result here's the necessary files plus patch for the
> current CVS version.

It introduces a new field type, FT_UINTVAR, which is a "Variable length
UINT"; that type appears to be a sequence of octets, with the last octet
not having the topmost bit set, with the value built by assembling the
lower 7 bits of each octet into a bit string.

This is, I think, also the encoding of ASN.1 tag values - but it's still
somewhat specialized.  Should we add a new type for this, or should we
just treat it as FT_UINT32, but have the a routine in the WAP dissector
extract the value and then use "proto_tree_add_uint()" to add an entry
with the extracted value rather than using "proto_tree_add_item()"?

If we do add a new type for this, should we add a mechanism by which
arbitrary dissectors can add new types without changing the Ethereal
core, rather than adding new FT_ values to the core as needed?