Ethereal-dev: Re: [ethereal-dev] Visited is zero after a filter operation ...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Wed, 23 Aug 2000 23:23:14 -0700
On Wed, Aug 23, 2000 at 10:59:16AM -0700, Guy Harris wrote:
> At this point, *I'd* vote for biting the bullet, not resetting the
> visited flag on a rescan, and not calling "conversation_init()" or
> "init_all_protocols()" on a rescan, and fixing all dissectors that this
> breaks, rather than coming up with more elaborate workarounds for
> clearing out all information on a rescan.

Well, I fixed the RPC dissector not to require that its data structures
be re-initialized on a rescan - and, in the process, allowed it to put
into the protocol tree for a reply an indication of the frame containing
the (first instance of the) request to which it's a reply, snoop-style.

I then removed the calls to "conversation_init()" and
"init_all_protocols()" on rescans of the capture file, and removed the
resetting of the visited flag.

If this breaks any dissectors, those dissectors should be fixed; I'll
look at the other dissectors that registered init routines, and at
dissectors that manipulate conversations, to see if they need fixing.