Ethereal-dev: Re: [ethereal-dev] Bug in Add Color to Protocols

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <sharpe@xxxxxxxxxx>
Date: Thu, 27 Jul 2000 02:41:52 +0900
At 02:25 AM 7/27/00 +0900, Richard Sharpe wrote:
>Hi,
>
>documenting causes me to do funny things.
>
>I clicked on New in the Add Color to Protocols dialog box, to bring up the
>Edit Color dialog box. Then I lost it, so I clicked on new again, and
>brought up a new one. Filled in, but things did not work. So I cliked
>cancel on the new one, found the old one and clicked on OK, and Ethereal
>crashed ... I will look at a fix now.
 
OK, found it. In gtk/color_dlg.c, color_new_cb calls
edit_color_filter_dialog_new with &filt_name_entry, a static that has a
comment above it saying that it should not be static.

I will bet that the call back that handles the cancel button from the
edit_color_filter dialog box sets &filt_name_entry to NULL or something.

I think that we should enforce that there is only one edit_color_filter
dialog box up at one time. Makes the interface more intuitive.

Regards
>-------
>Richard Sharpe, sharpe@xxxxxxxxxx
>Samba (Team member, www.samba.org), Ethereal (Team member, www.zing.org)
>Contributing author, SAMS Teach Yourself Samba in 24 Hours
>Author, Special Edition, Using Samba
>
>
>

Regards
-------
Richard Sharpe, sharpe@xxxxxxxxxx
Samba (Team member, www.samba.org), Ethereal (Team member, www.zing.org)
Contributing author, SAMS Teach Yourself Samba in 24 Hours
Author, Special Edition, Using Samba