Hi all,
The WAP dissector is coming along nicely now - I've fixed a few things in Ben's
initial implementation, expanded the WTP support and started the WSP support.
Its been an interesting learning exercise and I thought I'd drop a few thoughts
to the list:
1. I find the current layout difficult to use on my monitor, so I've hacked in
an "alternative layout" flag in the preferences file. This is checked in the
main window creation code and if set to true it places the packet list and tree
view windows side-by-side with the byte view underneath. I find that easier to
use - let me know if anyone else would like the code.
2. The WSP protocol uses a byte encoding scheme that uses the msb to indicate
whether the value continues into the next byte and the remainder of the
octet to hold the value. If set, the value should be shifted left 7 places and
the next octet parsed. To do this I've written a tvb function similar to
the tvb_get_guint functions that returns the value *and* the number of octets
read to get the final value. At the moment I've put this function in tvbuff.c,
but it occurs to me that it may be a WSP-specific method. Any thoughts on
whether it should stay there or move to the WSP file?
3. In WSP, strings are stored *without* their trailing 0x00 - any thoughts on
whether it should be the application that is responsible for appending a
missing null before displaying a string, or whether Ethereal should insert a
null at the end of the requested length of string if one is missing? (At the
moment I'm doing it).
Cheers,
Neil
-------------------------------------------------------------------------------
Neil Hunter Tel: +44 (0)113 207 6073
Internet Systems Developer Fax: +44 (0)113 234 6065
Energis Squared Mobile: +44 (0)7787 100 649
http://www.energis-squared.com/
---------------------------------------
This email is confidential and may be privileged. If you are not the named
recipient please notify the sender immediately and do not disclose to
another person or use it and take copies. If you receive this message in
error please call the switchboard on + 44 (0)113 234 5100.
-------------------------------------------------------------------------------
