Ethereal-dev: Re: [ethereal-dev] [patch] code for dissecting X11 requests

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Christophe Tronche" <ch.tronche@xxxxxxxxxxxx>
Date: Mon, 12 Jun 2000 22:57:06 +0200
> There's a comment in "packet-x11.c" that says
> 
> 	 * - add hidden fields so we can have x11.circulate-window in addition
> 	     to x11.opcode == 13
> 
> At some point, we should add support for, in filter expressions,
> comparing "enumerated" fields (fields with a "value_string" table
> associated with them) with the strings from the table.  That should
> handle that case, as well as similar items in other protocols.
> 
> Another comment says
> 
> 	 * - use a faster scheme that linear list searching for the opcode.
> 
> If that's referring to searching the "value_string" table, we might also
> want to make a general way of doing e.g. hashed lookups in those tables.

Yes, it's value_string we're talking about here. Do you mean you want
a way to systematically perform lookups through a hash table ? Since
many string tables are short (<= 10 entries) for many protocols, it
wouldn't be such a performance boost (or it could even make the
program slower ???). I think the decision should be left to the
dissector programmers, who already have a way to do it.

Just my 0.02.

-- 
Christophe Tronche	ch.tronche@xxxxxxxxxxxx
marchFIRST (France)	http://tronche.com/