Ethereal-dev: Re: [ethereal-dev] Bug report: edit/filters/apply does not work

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Fri, 9 Jun 2000 23:07:59 -0700
On Thu, Jun 08, 2000 at 03:02:47PM +0100, Johannes Hennecke wrote:
> If I choose "Edit/Filters ...", mark one of my saved filters and do "Apply", the
> filter is not applied to the display.

Yes, "Apply" in "Edit/Filters" doesn't apply to the display; to do that,
you can, instead, click the "Filter:" button next to the filter text
entry box at the bottom of the main window, which will pop up the same
dialog box, but "Apply" will make it the current display filter.

I'll have to go see if I can find the mail that triggered my changing
the code to pop up filter dialog boxes; I think it was, at least in
part, triggered by a bug, and the intent was to, for one thing, allow
only one of those dialog boxes to be displayed at a time.

It's a bit tricky to arrange that if you edit the list of filters in one
dialog box, the other dialog boxes update automatically to reflect the
new list; I think it might be fixable, although if you allow more than
one such dialog box open, you may run the risk that the user will forget
which particular filter the dialog box is associated with and get
confused.  (I've tried to avoid using modal dialog boxes, so that if you
need to look at some other stuff in the application in order to fill in
a dialog box, you're not stuck; I've been irritated by some applications
with modal dialog boxes that put me in that position.  However, that
runs the risk that you can have more than one thing going on at once,
which could confuse the user, and definitely makes the code more
complicated as it either has to deal with state changing out from under
some dialog box or somehow block those state changes.)