Ethereal-dev: [ethereal-dev] initial X11 dissector close to completion, but...
...I've one question before.
Don't hope too much from this version by the way, it can only decode
requests for now (not events nor replies).
It was written without tvbuff at first, so it doesn't really use them.
Counted and unicode strings would have been useful, but it's for the
next time.
Now the question:
I've got a lot of header fields (about 370 of them). To keep things
manageable, I've put them in a text file, with a short Perl script
(very specific to my needs) to create the register info and variable
declarations in two .h files, then #included in the packet-x11.c file
(I remember having seen this kind of things discussed before). If I
send a patch for that, we got two bizarre files in the distribution
(the text file and the script), and four files for x11 (packet-x11.c,
packet-x11.h, packet-x11-register-info.h and
packet-x11-declarations.h), while I remember that some efforts have
been done in the past so that only two files (packet-xxx.h and
packet-xxx.c) were left for any protocol.
The alternative is to include directly the packet-x11-declarations.h
and packet-x11-register-info.h into the packet-x11.c and keep the text
file for myself, however it's gonna make things more difficult for
future maintenance (especially for other people than myself), and
further more, isn't very readable.
Enlightened opinion someone ?
--
Christophe Tronche ch.tronche@xxxxxxxxxxxx
marchFIRST (France) http://tronche.com/
