Ethereal-dev: Re: [ethereal-dev] Ethereal C++ compatability

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date: Tue, 30 May 2000 11:05:52 +0200
> What happens if you change the typedefs to
>
>	typedef GNode proto_tree;
>	typedef GNode proto_item;

Works for me


Now that I'm cleaning up some things. A lot of calls generate 
warnings, because they are defined like this:

	void function( unsigned char a, guint8 b)
	{
	}

and they are called like this:
	int a;
	char aa;
	int b;	guint8 bb;
	guint16 bbb;

	function( a, b );
or
	function ( aa, bbb);
etc.

Basically, the supplied parameter type is too big (ie one or more bytes)
for the defined parameter type.

The following files (among others) have this "problem":
- packet-esis.c:
	esis_dissect_esh_pdu()
- packet-radius.c
	rdconvertbuftostr()
- packet_osi_options.c
	dissect_options_qos
- packet-null.c
	capture_ethertype()

These are not severe problems, but they can very easily lead 
to errors. Besides, it's just general sloppy programming IMHO.

The WinDump source redefines "inline" without checking if it's not 
already defined, but GLib also doesn't check, so...

-- 
Andreas Sikkema
andreas.sikkema@xxxxxxxxxxx
"Standing barefoot in a river of clues, most people would 
         not get their toes wet." - Brian Kantor in a.s.r.