Ethereal-dev: Re: [ethereal-dev] Padding patch for packet-smb.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Thu, 25 May 2000 01:34:55 -0700
> I have been using the marvellous ethereal to dissect some naughty SMB
> packets and believe that ethereal's treatment of the pad1 & pad2
> fields in some SMBs is incorrect. In particular, the original code
> assumes that some data needs aligning on a 2 byte boundary but it may
> be aligned on a 4 byte boundary (according to the CIFS/1.0 spec I
> have).
> 
> The enclosed patch should improve matters.

Checked in.

Note that much of that code is, I think, automatically generated by a
script that Richard Sharpe has; if so, it might be a good idea to have
the script, and the file or files it reads, checked into the source
tree, so that changes such as this one, and Gilbert's tvbuffification
changes, can be made to the script, so that changes to the generated
"packet-smb.c" aren't lost if "packet-smb.c" is regenerated.