Ethereal-dev: Re: [ethereal-dev] Regarding EIGRP dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Fri, 19 May 2000 10:53:38 -0700
On Fri, May 19, 2000 at 05:16:47PM +0300, Paul Ionescu wrote:
> I know that EIGRP is a multiprotocol routing protocol (Cisco
> proprietary).
> In fact is for IP,IPX and AppleTalk.
> Currently, in Ethereal is only considered as IP routing protocol and as
> such is defined as "static" in packet-ip.c file.
> I can make a patch to include detection of EIGRP for IPX and AppleTalk
> and after the detection to pass the packet to dissect_eigrp() function,
> but in this case the dissect_eigrp() should be declared as global
> function not as static and eventualy moved into a new file like
> packet-eigrp.c and a header packet-eigrp.h .
> 
> What do you think about that ?

If it's encapsulated in more than IP, then it should go into its own
file.

However, if all the protocols in which it's encapsulated support
"dissector_add()"-style tables, it doesn't have to be global;
unfortunately, IPX and AppleTalk currently don't support them, so, for
now, it'd have to be global.