Ethereal-dev: Re: [ethereal-dev] Patch for file.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxx>
Date: Fri, 12 May 2000 11:32:49 -0700 (PDT)
> 4) Change in white space. Where do you like spaces and parentheses?
> I put 1 space after each opening parenthesis and before each closing
> parenthesis.

It is not certain that there is a single "you" to be asked here that
would speak with a single voice.

If I write a new source module, I use K&R Normal Form, as modified for
function prototypes, i.e.

	int
	foo(int a, char *b)
	{
		int c;

		c = *b + 17;
		if (c == 35) {
			*b = a + 45;
			c = 66;
		} else if (c + a == 25) {
			*b = 73;
			c = a + 12;
		} else
			c = c + *b + a + 137;
		return a + *b + c<<3;
	}

but others use other styles, some of which involve spaces after "(" and
before ")", others of which don't.

I *personally* don't like spaces after "(" or before ")"; others
apparently do like them, given that their code uses them.