I didn't catch up with this thread until this morning, but last night at
home I came to the same conclusion , although I made "c" a gint as the man
pages for all the is<whatever>() show that the parameter should be an int.
This seemed to work equally well so it's up to you whether you leave "c" as
a guchar or make it a gint.
I brought up the setlocale issue as my little test app which was basically
the ethereal hex dump code cut and pasted didn't show the problem, and it
definitely affected the result of isgraph().
I have attached some more patches to correct the following things on the
win32 port:
1. Modified config.nmake to set path to cygwin for tools and to allow
register.c to be built
2. Modified Makefile.nmake to produce register.c
3. Modified Makefile.nmake wiretap\Makefile.nmake & plugins\Makefile.nmake
to correctly clean objects
-----Original Message-----
From: Guy Harris [mailto:gharris@xxxxxxxxxxxx]
Sent: 28 April 2000 07:14
To: Guy Harris
Cc: Graham Bloice; ethereal-dev@xxxxxxxx
Subject: Re: [ethereal-dev] Hex dump problem?
> Try applying both Gilbert's and my patch (mine patches code with his
> change in it), or check out the latest code from CVS, and see if that
> works (I may try that at home this evening, although I have seen other
> problems with the latest GTK+-for-Windows, e.g. clicking on frames in
> the packet list pane causes at pane to scroll horizontally all the way
> to the right).
The latest version of the GTK+-for-Win32, plus the latest Ethereal from
CVS, appears
1) not to have the weird packet-list scrolling problem that I
remember from the another version;
2) appears to handle the hex pane no worse than the 19990828
version we've saved on the Ethereal site (both of them draw
boldface characters wider than normal characters, for some
reason).
Attachment:
config.nmake
Description: Binary data
Attachment:
makefile.nmake
Description: Binary data
Attachment:
plugins.makefile.nmake
Description: Binary data
Attachment:
wiretap.makefile.nmake
Description: Binary data
