Ethereal-dev: Re: [ethereal-dev] Wish-List item #32

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Sat, 04 Mar 2000 20:47:31 -0600
On Sun, Mar 05, 2000 at 12:04:43PM +0800, Paul D. Walker wrote:
> Hi Guys, 
> 
> This small patch allows you to sort the contents of the packet window by
> clicking on the appropriate header.
> 
> If you like it, you can include it.  Oh, the comment sucks.  It's 4am and it
> seemed ok an hour ago.
> 
>  - Paul
> pdwalker@xxxxxxxxxxxx

Thanks.  There's a couple of problems with it, though.

Our "select_packet" routine in file.c, which is called when
a packet is selected in the CList, is picking up the wrong packet
and thus displaying the wrong info in the decode tree. It's using
the CList row regardless of what number packet is in that row.

Interestingly, the "Show packet in new window" function _does_
work correctly, even if the decode tree is incorrect.

Also, there's no way to return the CList to its original order.
Sorting on the "No." column won't work, since "10" gets sorted before
"2". And since the columns that a user sees are user-configurable,
it is possible (although highly unprobably) that a user could
have no "No." column at all. (Really, in that case, the user gets
what he deserves.)

--gilbert