Ethereal-dev: Re: [ethereal-dev] pptp error?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Wed, 19 Jan 2000 23:35:12 -0800
> The change, however, appears to convert code that dereferences
> possibly-unaligned pointers to code that dereferences possibly-unaligned
> pointers and then puts the result in network byte order, so it's not the
> right way to fix the problem - the right way is to use "pntohs()" and
> "pntohl()".

I've checked in a fix that fixes that problem as well (and gets rid of
one "ntohs()" call that was handing "ntohs()" a value that had already
been put in host byte order), and sent the patch for that fix off to the
guy who submitted the bug and the Debian developer whose name appears in
the bug report.