Ethereal-dev: [ethereal-dev] Fix for packet-q931.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Bert Driehuis <driehuis@xxxxxxxxxxxxx>
Date: Tue, 14 Dec 1999 19:00:10 +0100
Upon inspection, the code was correct but one of the #defines was
causing the problem for European Q.931. I have a hard time believing the
original #define was right...

Plus, this diff fixes the time display.

Cheers,

					-- Bert
-- 
Bert Driehuis -- driehuis@xxxxxxxxxxxxx -- +31-20-3116119
The grand leap of the whale up the Fall of Niagara is esteemed, by all
who have seen it, as one of the finest spectacles in nature.
                -- Benjamin Franklin.
*** /work/bertd/build/gnome/cvs/ethereal/packet-q931.c	Thu Nov 25 23:49:01 1999
--- ./packet-q931.c	Tue Dec 14 12:13:53 1999
***************
*** 141,145 ****
   * Single-octet IEs.
   */
! #define	Q931_IE_SO_IDENTIFIER_MASK	0x70	/* IE identifier mask */
  #define	Q931_IE_SO_IDENTIFIER_SHIFT	4	/* IE identifier shift */
  #define	Q931_IE_SO_IE_MASK		0x0F	/* IE mask */
--- 141,145 ----
   * Single-octet IEs.
   */
! #define	Q931_IE_SO_IDENTIFIER_MASK	0xf0	/* IE identifier mask */
  #define	Q931_IE_SO_IDENTIFIER_SHIFT	4	/* IE identifier shift */
  #define	Q931_IE_SO_IE_MASK		0x0F	/* IE mask */
***************
*** 1387,1391 ****
  	 */
  	proto_tree_add_text(tree, offset, 6,
! 	    "Date/time: %u-%u-%u %u:%u:%u",
  	    pd[offset + 0], pd[offset + 1], pd[offset + 2],
  	    pd[offset + 3], pd[offset + 4], pd[offset + 5]);
--- 1387,1391 ----
  	 */
  	proto_tree_add_text(tree, offset, 6,
! 	    "Date/time: %02u-%02u-%02u %02u:%02u:%02u",
  	    pd[offset + 0], pd[offset + 1], pd[offset + 2],
  	    pd[offset + 3], pd[offset + 4], pd[offset + 5]);