Ethereal-dev: Re: [ethereal-dev] requested change to packet-rpc.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxx>
Date: Sun, 14 Nov 1999 15:39:57 -0800 (PST)
> Would there be any objections to having packet-rpc.c include the Program
> Version, and Procedure in the program subtree?

Sounds reasonable.  "snoop" shows:

RPC:  ----- SUN RPC Header -----
RPC:
RPC:  Transaction id = 533904779
RPC:  Type = 0 (Call)
RPC:  RPC version = 2
RPC:  Program = 100003 (NFS), version = 2, procedure = 1
RPC:  Credentials: Flavor = 1 (Unix), len = 44 bytes
RPC:     Time = 04-Jan-97 02:22:43  
RPC:     Hostname = linda-indy
RPC:     Uid = 1229, Gid = 0   
RPC:     Groups = 30 32 204
RPC:  Verifier   : Flavor = 0 (None), len = 0 bytes
RPC:
NFS:  ----- Sun NFS -----
NFS:
NFS:  Proc = 1 (Get file attributes)
NFS:  File handle = 22C00300495301000000000022C00300
NFS:                495301000000000022C0030049530100
NFS:

for calls and

RPC:  ----- SUN RPC Header -----
RPC:
RPC:  Transaction id = 533904779
RPC:  Type = 1 (Reply)
RPC:  This is a reply to frame 1
RPC:  Status = 0 (Accepted)
RPC:  Verifier   : Flavor = 0 (None), len = 0 bytes
RPC:  Accept status = 0 (Success)
RPC:  
NFS:  ----- Sun NFS -----
NFS:
NFS:  Proc = 1 (Get file attributes)
NFS:  Status = 0 (OK)
NFS:  File type = 2 (Directory)
NFS:  Mode = 040775
NFS:   Type = Directory
NFS:   Setuid = 0, Setgid = 0, Sticky = 0
NFS:   Owner's permissions = rwx
NFS:   Group's permissions = rwx
NFS:   Other's permissions = r-x
NFS:  Link count = 19, UID = 118, GID = 204
NFS:  File size = 4096, Block size = 8192, No. of blocks = 8
NFS:  File system id = 0, File id = 245794
NFS:  Access time       = 04-Jan-97 02:23:21.730001 GMT
NFS:  Modification time = 20-Nov-96 01:46:18.700000 GMT
NFS:  Inode change time = 20-Nov-96 01:46:18.700000 GMT
NFS:  

for replies, showing the procedure number, for both calls and replies,
in the dissection of the particular ONC RPC operation, and Network
Monitor shows:

  RPC: Call: Network File System(NFS), Procedure 1 (0x1)
      RPC: Transaction ID = 533904779 (0x1FD2BD8B)
      RPC: Message type = Service call
      RPC: RPC Version number = 2 (0x2)
      RPC: Program Number = Network File System(NFS)
      RPC: Program Version = 2 (0x2)
      RPC: Procedure Number = 1 (0x1)
    + RPC: Authentication Credentials
    + RPC: Authentication Verification
      RPC: Data: Number of data bytes remaining = 32 (0x0020)
  NFS: "Get File Attributes" Call
      NFS: Procedure = Get File Attributes
      NFS: File Handle = 22C00300495301000000000022C00300495301000000000022C0030049530100

for calls and

  RPC: Reply: Message accepted, Call succeeded
      RPC: Transaction ID = 533904779 (0x1FD2BD8B)
      RPC: Message type = Service reply
      RPC: Acceptance Status = Message accepted
    + RPC: Authentication Verification
      RPC: Call status = Call succeeded
      RPC: Data: Number of data bytes remaining = 72 (0x0048)
  NFS: "Get File Attributes" Reply, -rwxrwxr-x Owner(Uid/Gid)=118/204
      NFS: Return Status = Success
      NFS: NFS File Attributes
          NFS: File Type = Directory
        + NFS: File Mode = 16893 (0x41FD)
          NFS: Number of Links = 19 (0x13)
          NFS: Owner UID = 118 (0x76)
          NFS: Owner GID = 204 (0xCC)
          NFS: File Size = 4096 (0x1000)
          NFS: File Block Size = 8192 (0x2000)

for replies, showing it in the calls (but not the replies).

I'd be inclined to go with your:

> RPC
> 	...
> 	Program Version: 2
> 	Procedure: DOMAIN (1)
> 	...
> Yellow Pages Service
> 	Program Version: 2
> 	Procedure: DOMAIN (1)
> 	...

showing both version and procedure.