Ethereal-dev: Re: [ethereal-dev] Core dumps

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Sun, 14 Nov 1999 11:53:57 -0800
On Sun, Nov 14, 1999 at 06:06:13AM -0600, Gilbert Ramirez wrote:
> On Sun, Nov 14, 1999 at 12:02:00PM +0100, Laurent Deniel wrote:
> > 
> > Hi,
> > 
> > It seems that the current CVS version is less stable than the previous
> > ones: I've got several segmentation violations and stack overflows while
> > loading multiple captured files in the same session. I'll try to figure
> > out what's going wrong ...
> > 
> > Laurent.
> 
> By loading/closing/loading/closing files I was able to get a core dump.
> The stack trace is:
> 
> #0  0x805ecf4 in conversation_init () at conversation.c:182

Unless somebody's changed "conversation.c" since my last "cvs update"
(and I didn't see any checkins for it since then), that's

	g_free((gpointer)key->src.data);

which suggests that the list of conversation keys is bad.

I suspect the problem might be that "conversation_init()" doesn't set
"conversation_keys" to NULL after destroying all the conversation keys. 
(Why that didn't show up all the way back to 0.7.7, I don't know.)  I'll
check in a fix for that (and for other "not setting a pointer to null
after destroying that to which it points" problems therein).