Ethereal-dev: Re: [ethereal-dev] issue with packet-rpc.c - rpc_init_prog

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 10 Nov 1999 15:15:59 -0800 (PST)
> I'd like to see packet-rpc.c changed to convert the progname to uppercase
> before putting it into the COL_PROTOCOL column, or alternatively, which is
> probably better - just change rpc_prog_init to take the protocol name to use
> for COL_PROTOCOL as an argument.  

"progname" appears to be used only to put stuff in the COL_PROTOCOL and
COL_INFO columns and in the "Program:" item in the tree, and I'm
generally used to seeing the names in all caps (that's the way "snoop"
appears to display them).

I could also, at some point, see the protocol name for most, if not all,
packets being set by attaching the index for a registered protocol to
the packet; given that, perhaps "proto_register_protocol()" should
supply:

	1) a descriptive name for the protocol;

	2) an presumably all-lower-case name for the protocol, to use in
	   filters;

	3) an short name for the protocol, probably not all lower case
	   and likely all upper case, to be used in COL_PROTOCOL and
	   possibly other places;

and "rpc_init_prog()" would then use the third name in that list for
"progname".